DataConverter incorrectly placed a fall_distance value with 0.0
if the entity did not have a FallDistance entry. This results in the
entity spawn data having 2 entries, which prevents finalisation
logic from running.
We can fix this by removing the fall_distance entry if it is 0.0.
In 1.21.8 there will be a proper fix for this and the patch can be
dropped.
It looks like BaseSpawner will not run natural spawn finalization
unless the entire data tag only contains the ID.
This only fixes converting old data, we need a fix for already
converted data.
This implements a solution that preemptively exits the tick loop if we have already marked the connection as disconnecting. This avoids changing the result of Connection#isConnected in order to avoid other possibly unintentional changes. Fundamentally it should be investigated if closing the connection async is really still needed.
This also additionally removes the login disconnecting logic for server stopping, as this was also a possible issue in the config stage but also shouldn't be an issue as connections are closed on server stop very early.
Additionally, do not check for isConnecting() on VERIFYING, as that seemed to be an old diff originally trying to resolve this code, however isConnected is not updated at this point so it pretty much was useless.
We are already using the dropped stack to determine the type, we
might as well also use it for the count, given that plugins can already
mutate the type, might as well let them mess with the amount.
Fixes#12745
That cooked is mildly cooked and should be fixed differently, e.g. a custom loot context param, but reverting the recent change in this line works for now
When converting entity/poi data (SimpleRegionStorage),
we need to insert the new data version so that force upgrading
will write the data back with the correct version.
Jason Penilla
Spottedleaf
Shane Freeder
Clexus
Brokkonaut
Jake Potrebic
Lach
David
caramel
partydev
Bjarne Koll
Nassim Jahnke
Owen
Newwind
Pedro
masmc05
Noah van der Aa
FlorianMichael
Lulu13022002
Kezz