The player teleport has been moved up in ThrownEnderpearl to prevent
endermite spawning in case of a cancelled teleport. This however placed
the player at the teleport destination prior to the endermite spawn
logic, creating the entity at the wrong location.
The commit stores the location of the player pre teleportation and uses
said location for spawning the endermite instead.
Co-authored-by: Helvetica Volubi <suisuroru@blue-millennium.fun>
Reviewed-in: https://github.com/PaperMC/Paper/pull/12912
Correctly return the resource pack status from Player#getResourcePackStatus()
when the resource pack was send and accepted during the configuration stage.
DataConverter incorrectly placed a fall_distance value with 0.0
if the entity did not have a FallDistance entry. This results in the
entity spawn data having 2 entries, which prevents finalisation
logic from running.
We can fix this by removing the fall_distance entry if it is 0.0.
In 1.21.8 there will be a proper fix for this and the patch can be
dropped.
It looks like BaseSpawner will not run natural spawn finalization
unless the entire data tag only contains the ID.
This only fixes converting old data, we need a fix for already
converted data.
This implements a solution that preemptively exits the tick loop if we have already marked the connection as disconnecting. This avoids changing the result of Connection#isConnected in order to avoid other possibly unintentional changes. Fundamentally it should be investigated if closing the connection async is really still needed.
This also additionally removes the login disconnecting logic for server stopping, as this was also a possible issue in the config stage but also shouldn't be an issue as connections are closed on server stop very early.
Additionally, do not check for isConnecting() on VERIFYING, as that seemed to be an old diff originally trying to resolve this code, however isConnected is not updated at this point so it pretty much was useless.
We are already using the dropped stack to determine the type, we
might as well also use it for the count, given that plugins can already
mutate the type, might as well let them mess with the amount.
Fixes#12745
That cooked is mildly cooked and should be fixed differently, e.g. a custom loot context param, but reverting the recent change in this line works for now
MC_XiaoHei
Warrior
Moulberry
Esophose
Strokkur24
Emil
swim5678
Jason Penilla
Alejandro Nieto
Lumine1909
Pedro
Emily
Bjarne Koll
Gero
TonytheMacaroni
Noah van der Aa
David
David Mayr
Alejandro Nieto
Nassim Jahnke
ookiegajwa
Jake Potrebic
metabrix
Spottedleaf
Shane Freeder
Brokkonaut
Owen
Lulu13022002